Skip to content

[0.82] Cherry-pick follow-ups to Hermes V1 opt-in#53705

Merged
vzaidman merged 3 commits intofacebook:0.82-stablefrom
j-piasecki:@jpiasecki/hermes-v1-followup
Sep 15, 2025
Merged

[0.82] Cherry-pick follow-ups to Hermes V1 opt-in#53705
vzaidman merged 3 commits intofacebook:0.82-stablefrom
j-piasecki:@jpiasecki/hermes-v1-followup

Conversation

@j-piasecki
Copy link
Copy Markdown
Contributor

@j-piasecki j-piasecki commented Sep 10, 2025

Summary:

Cherry-picks #53637, #53665 and #53725 onto 0.82 stable

Changelog:

[ANDROID][FIXED] - Check for the value of the HERMES_V1_ENABLED flag instead of whether it's defined
[ANDROID][FIXED] - Read the Hermes V1 opt-in flag from the apps properties when building from source
[GENERAL][CHANGED] - Changed the coordinates of hermes artifacts when using Hermes V1

…cebook#53637)

Summary:
Pull Request resolved: facebook#53637

Changelog: [ANDROID][FIXED] - Check for the value of the HERMES_V1_ENABLED flag instead of whether it's defined

Reviewed By: cortinico

Differential Revision: D81920483

fbshipit-source-id: 550ae9fd27f666affe102b1c5c3f51bde7b5923e
Summary:
Pull Request resolved: facebook#53665

Changelog: [ANDROID][FIXED] - Read the Hermes V1 opt-in flag from the apps properties when building from source

Reviewed By: cortinico

Differential Revision: D82018545

fbshipit-source-id: f3c6fdbac190f47b6bf6836105d9e0909d8b86ba
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@facebook-github-bot facebook-github-bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 10, 2025
@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Sep 10, 2025

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against c2f5146

…acebook#53725)

Summary:
Pull Request resolved: facebook#53725

Changelog: [GENERAL][CHANGED] - Changed the coordinates of hermes artifacts when using Hermes V1

Adds a new `version.properties` file to keep which hermes versions should be consumed from Maven once the versions of Hermes and React Native are decoupled. This diff only implements changes necessary for consuming Hermes V1, as we don't want to migrate everything quite yet (0.82).

Reviewed By: cortinico

Differential Revision: D82204203

fbshipit-source-id: d712257a73f7ba54612a55c1b312416376f28b56
@vzaidman vzaidman merged commit 4c53204 into facebook:0.82-stable Sep 15, 2025
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants